staging: rtl8192u: fix a dubious looking mask before a shift
authorColin Ian King <colin.king@canonical.com>
Thu, 16 Jul 2020 15:47:20 +0000 (16:47 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jul 2020 10:08:44 +0000 (12:08 +0200)
commitc4283950a9a4d3bf4a3f362e406c80ab14f10714
treecf23aad48398a0e8f59165c73801255b13d75f30
parentf6b35db072dcf25365972503ade853960da5c984
staging: rtl8192u: fix a dubious looking mask before a shift

Currently the masking of ret with 0xff and followed by a right shift
of 8 bits always leaves a zero result.  It appears the mask of 0xff
is incorrect and should be 0xff00, but I don't have the hardware to
test this. Fix this to mask the upper 8 bits before shifting.

[ Not tested ]

Addresses-Coverity: ("Operands don't affect result")
Fixes: 8fc8598e61f6 ("Staging: Added Realtek rtl8192u driver to staging")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200716154720.1710252-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/r8192U_core.c