soc: bcm: brcmstb: biuctrl: fix of_iomap leak
authorZhaoyang Li <lizhaoyang04@hust.edu.cn>
Mon, 27 Mar 2023 11:54:22 +0000 (19:54 +0800)
committerFlorian Fainelli <f.fainelli@gmail.com>
Mon, 3 Apr 2023 20:37:24 +0000 (13:37 -0700)
commitc3fbced9af885a6f217fd95509a613d6590916ce
tree268daf1fefa6a0485fa9b4f1095f091555d1f575
parent69160dd0aa6832b98d272c1a224b1aaf67cf843d
soc: bcm: brcmstb: biuctrl: fix of_iomap leak

Smatch reports:

drivers/soc/bcm/brcmstb/biuctrl.c:291 setup_hifcpubiuctrl_regs() warn:
'cpubiuctrl_base' from of_iomap() not released on lines: 291.

This is because in setup_hifcpubiuctrl_regs(),
cpubiuctrl_base is not released when handle error, which may cause a leak.
To fix this, iounmap is added when handle error.

Fixes: 22f7a9116eba ("soc: brcmstb: Correct CPU_CREDIT_REG offset for Brahma-B53 CPUs")
Signed-off-by: Zhaoyang Li <lizhaoyang04@hust.edu.cn>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/r/20230327115422.1536615-1-lizhaoyang04@hust.edu.cn
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
drivers/soc/bcm/brcmstb/biuctrl.c