projects / platform / kernel / linux-rpi.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 065d099) | patch
leds: Fix BUG_ON check for LED_COLOR_ID_MULTI that is always false
authorMarek Behún <kabel@kernel.org>
Tue, 1 Aug 2023 15:16:23 +0000 (17:16 +0200)
committerLee Jones <lee@kernel.org>
Thu, 17 Aug 2023 10:26:36 +0000 (11:26 +0100)
commitc3f853184bed04105682383c2971798c572226b5
tree4b25ac7a340d31369615c5bd7e25653ce029e5a6tree | snapshot
parent065d099f1be58187e6629273c50b948a02b7e1bfcommit | diff
leds: Fix BUG_ON check for LED_COLOR_ID_MULTI that is always false

At the time we call
    BUG_ON(props.color == LED_COLOR_ID_MULTI);
the props variable is still initialized to zero.

Call the BUG_ON only after we parse fwnode into props.

Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now")
Signed-off-by: Marek Behún <kabel@kernel.org>
Link: https://lore.kernel.org/r/20230801151623.30387-1-kabel@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/led-core.c diff | blob | history
Domain: System / Kernel;