ADT: Avoid repeating iterator adaptor/facade template params, NFC
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Fri, 12 Nov 2021 21:50:29 +0000 (13:50 -0800)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Fri, 12 Nov 2021 22:00:08 +0000 (14:00 -0800)
commitc3edab8f781d0c3cf063ec0c675ad7bd7c3b65b8
tree569107f18874075b4c084ce5e08e6c80d320447f
parente2a86ab8474eec1a427a71b1b4795830cf068c3e
ADT: Avoid repeating iterator adaptor/facade template params, NFC

Take advantage of class name injection to avoid redundantly specifying
template parameters of iterator adaptor/facade base classes.

No functionality change, although the private typedefs changed in a
couple of cases.

  - Added a private typedef HashTableIterator::BaseT, following the
    pattern from r207084 / 3478d4b164e8d3eba01f5bfa3fc5bfb287a78b97, to
    pre-emptively appease MSVC (maybe it's not necessary anymore but
    looks like we do this pretty consistently). Otherwise, I removed
    private
  - Removed private typedefs filter_iterator_impl::BaseT and
    FilterIteratorTest::InputIterator::BaseT since there was only one
    use of each and the definition was no longer interesting.
llvm/include/llvm/ADT/STLExtras.h
llvm/include/llvm/DebugInfo/PDB/Native/DbiModuleList.h
llvm/include/llvm/DebugInfo/PDB/Native/HashTable.h
llvm/unittests/ADT/IteratorTest.cpp