spi: mediatek: Fix DEVAPC Violation at KO Remove
authorZhichao Liu <zhichao.liu@mediatek.com>
Thu, 10 Nov 2022 07:28:39 +0000 (15:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Dec 2022 10:37:15 +0000 (11:37 +0100)
commitc3b818c91a1111a5d9679ec6dc15c9bc54e2096f
tree312c5f4b15838385839ecd12d04bd4179d667183
parentd9f0107be1a973b9c89df52e8d0a23114aa98f98
spi: mediatek: Fix DEVAPC Violation at KO Remove

[ Upstream commit 0d10e90cee9eb57882b0f7e19fd699033722e226 ]

A DEVAPC violation occurs when removing the module
due to accessing HW registers without base clock.
To fix this bug, the correct method is:
1. Call the runtime resume function to enable the
   clock;
2. Operate the registers to reset the HW;
3. Turn off the clocks and disable the device
   RPM mechanism.

Signed-off-by: Zhichao Liu <zhichao.liu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20221110072839.30961-1-zhichao.liu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-mt65xx.c