[Modules] Do not diagnose missing import in recovery mode if there isn't a decl to...
authorBruno Cardoso Lopes <bruno.cardoso@gmail.com>
Wed, 16 May 2018 17:00:24 +0000 (17:00 +0000)
committerBruno Cardoso Lopes <bruno.cardoso@gmail.com>
Wed, 16 May 2018 17:00:24 +0000 (17:00 +0000)
commitc39e85d12cc5a174c51fd046b13a66255b342034
treecf5d54a1608d5d7c3fb7d595b23dec1ce6a1bdcf
parent11fd14c1ac219fcf0cebe1760dc459d1d5f20d87
[Modules] Do not diagnose missing import in recovery mode if there isn't a decl to lookup

Clang often tries to create implicit module import for error recovery,
which does a great job helping out with diagnostics. However, sometimes
clang does not have enough information given that it's using an invalid
context to move on. Be more strict in those cases to avoid crashes.

We hit crash on invalids because of this but unfortunately there are no
testcases and I couldn't manage to create one. The crashtrace however
indicates pretty clear why it's happening.

rdar://problem/39313933

llvm-svn: 332491
clang/lib/Sema/SemaType.cpp