sched/wait: Introduce prepare_to_wait_event()
authorOleg Nesterov <oleg@redhat.com>
Mon, 7 Oct 2013 16:18:24 +0000 (18:18 +0200)
committerIngo Molnar <mingo@kernel.org>
Wed, 16 Oct 2013 12:22:18 +0000 (14:22 +0200)
commitc2d816443ef305aba8eaf0bf368f4d3d87494f06
tree0331463c4ea621c1467e83894a9cebf3a91cb136
parent8922915b38cd8b72f8e5af614b95be71d1d299d4
sched/wait: Introduce prepare_to_wait_event()

Add the new helper, prepare_to_wait_event() which should only be used
by ___wait_event().

prepare_to_wait_event() returns -ERESTARTSYS if signal_pending_state()
is true, otherwise it does prepare_to_wait/exclusive.  This allows to
uninline the signal-pending checks in wait_event*() macros.

Also, it can initialize wait->private/func. We do not care if they were
already initialized, the values are the same. This also shaves a couple
of insns from the inlined code.

This obviously makes prepare_*() path a little bit slower, but we are
likely going to sleep anyway, so I think it makes sense to shrink .text:

               text    data      bss      dec     hex  filename
            ===================================================
   before:  5126092 2959248 10117120 18202460 115bf5c   vmlinux
    after:  5124618 2955152 10117120 18196890 115a99a   vmlinux

on my build.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20131007161824.GA29757@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
include/linux/wait.h
kernel/wait.c