Add switch: Do not resolve URLs by defaults for XML (#84169)
authorKrzysztof Wicher <mordotymoja@gmail.com>
Tue, 18 Jul 2023 09:13:18 +0000 (11:13 +0200)
committerGitHub <noreply@github.com>
Tue, 18 Jul 2023 09:13:18 +0000 (11:13 +0200)
commitc2bd0c9e6c83eaa1f542f84084f6718207db8e4e
treea7f52212eba8e1a402560a892e942e99ee7066f6
parentac3979aca410dc33396c95b1fe4b85424900f603
Add switch: Do not resolve URLs by defaults for XML (#84169)

* Add switch: Do not resolve URLs by defaults for XML

* feedback, test

* rename switch per API review

* Apply missed feedback, fix test failure

* Fix typo in IgnoreEmptyKeySequences

Co-authored-by: David Cantú <dacantu@microsoft.com>
* Update src/libraries/System.Private.Xml/tests/TrimmingTests/XmlUrlResolverDefaults.IsNetworkingEnabledByDefault.cs

Co-authored-by: David Cantú <dacantu@microsoft.com>
---------

Co-authored-by: David Cantú <dacantu@microsoft.com>
22 files changed:
src/libraries/Common/src/System/LocalAppContextSwitches.Common.cs
src/libraries/System.Private.Xml/src/ILLink/ILLink.Substitutions.xml [new file with mode: 0644]
src/libraries/System.Private.Xml/src/System.Private.Xml.csproj
src/libraries/System.Private.Xml/src/System/Xml/Core/LocalAppContextSwitches.cs
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlReader.cs
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlReaderSettings.cs
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlValidatingReaderImpl.cs
src/libraries/System.Private.Xml/src/System/Xml/Schema/XmlSchemaSet.cs
src/libraries/System.Private.Xml/src/System/Xml/XmlDownloadManager.cs
src/libraries/System.Private.Xml/src/System/Xml/XmlDownloadManagerAsync.cs [deleted file]
src/libraries/System.Private.Xml/src/System/Xml/XmlResolver.FileSystemResolver.cs [new file with mode: 0644]
src/libraries/System.Private.Xml/src/System/Xml/XmlUrlResolver.cs
src/libraries/System.Private.Xml/src/System/Xml/XmlUrlResolverAsync.cs [deleted file]
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Xslt/XsltLoader.cs
src/libraries/System.Private.Xml/src/System/Xml/Xslt/XslCompiledTransform.cs
src/libraries/System.Private.Xml/src/System/Xml/Xslt/XslTransform.cs
src/libraries/System.Private.Xml/tests/AllowDefaultResolverContext.cs
src/libraries/System.Private.Xml/tests/TrimmingTests/System.Private.Xml.TrimmingTests.proj
src/libraries/System.Private.Xml/tests/TrimmingTests/XmlUrlResolverDefaults.Disabled.IsNetworkingEnabledByDefault.cs [new file with mode: 0644]
src/libraries/System.Private.Xml/tests/TrimmingTests/XmlUrlResolverDefaults.IsNetworkingEnabledByDefault.cs [new file with mode: 0644]
src/libraries/System.Xml.ReaderWriter/ref/System.Xml.ReaderWriter.cs