block: Free queue resources at blk_release_queue()
authorHannes Reinecke <hare@suse.de>
Wed, 28 Sep 2011 14:07:01 +0000 (08:07 -0600)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 3 Oct 2011 18:41:13 +0000 (11:41 -0700)
commitc2b387f0295ffaeb5e96f0d6f745fde507abd651
tree9d817f12f4ecfa480ac1cc3b471af31837b30c8c
parentf0e47138b26bd26d312aa63522a579acac5552c6
block: Free queue resources at blk_release_queue()

commit 777eb1bf15b8532c396821774bf6451e563438f5 upstream.

A kernel crash is observed when a mounted ext3/ext4 filesystem is
physically removed. The problem is that blk_cleanup_queue() frees up
some resources eg by calling elevator_exit(), which are not checked for
in normal operation. So we should rather move these calls to the
destructor function blk_release_queue() as at that point all remaining
references are gone. However, in doing so we have to ensure that any
externally supplied queue_lock is disconnected as the driver might free
up the lock after the call of blk_cleanup_queue(),

Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
block/blk-core.c
block/blk-sysfs.c