ice: fix kernel BUG if register_netdev fails
authorJacob Keller <jacob.e.keller@intel.com>
Sat, 16 May 2020 00:42:25 +0000 (17:42 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 28 May 2020 22:51:28 +0000 (15:51 -0700)
commitc2b313b783e0441dab2441cc1ee216eb4b9447a6
tree6445f2980b0b4b647fe3ec2e322fd69030e70e55
parentbc3a024101ca497bea4c69be4054c32a5c349f1d
ice: fix kernel BUG if register_netdev fails

If register_netdev() fails, the driver will attempt to cleanup the
q_vectors and inadvertently trigger a kernel BUG due to a NULL pointer
dereference.

This occurs because cleaning up q_vectors attempts to call
netif_napi_del on napi_structs which were never initialized.

Resolve this by releasing the netdev in ice_cfg_netdev and setting
vsi->netdev to NULL. This ensures that after ice_cfg_netdev fails the
state is rewound to match as if ice_cfg_netdev was never called.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_main.c