net/at91_ether: avoid NULL pointer dereference
authorGilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Sun, 6 Apr 2014 18:37:44 +0000 (20:37 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Apr 2014 19:10:17 +0000 (15:10 -0400)
commitc293fb785bdda64d88f197e6758a3c16ae83e569
tree3c0e585c7e298d841f9c533ad8f7a8b526d1fef1
parent065d7e39563b092dbb429373bd8f0f2295768cea
net/at91_ether: avoid NULL pointer dereference

The at91_ether driver calls macb_mii_init passing a 'struct macb'
structure whose tx_clk member is initialized to 0. However,
macb_handle_link_change() expects tx_clk to be the result of
a call to clk_get, and so IS_ERR(tx_clk) to be true if the clock
is invalid. This causes an oops when booting Linux 3.14 on the
csb637 board. The following changes avoids this.

Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/at91_ether.c