st/mesa: check state->mesa in early return check in st_validate_state()
authorBrian Paul <brianp@vmware.com>
Wed, 6 Jan 2016 00:10:12 +0000 (17:10 -0700)
committerBrian Paul <brianp@vmware.com>
Wed, 6 Jan 2016 22:53:46 +0000 (15:53 -0700)
commitc28d72a3473ad0127c82c1244b6688dcc184e85e
treeee69f6b9a086aefc516c848cfa9f0a4353c34dcf
parentc75d00e054c02ac32321ee0a4e6e2932ad2ad6ad
st/mesa: check state->mesa in early return check in st_validate_state()

We were checking the dirty->st flags but not the dirty->mesa flags.
When we took the early return, we didn't clear the dirty->mesa flags
so the next time we called st_validate_state() we'd often flush the
glBitmap cache.  And since st_validate_state() is called from
st_Bitmap(), it meant we flushed the bitmap cache for every glBitmap()
call.

This change seems to recover most of the performance loss observed
with the ipers demo on llvmpipe since commit commit 36c93a6fae27561.

Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: José Fonseca <jfonseca@vmware.com>
src/mesa/state_tracker/st_atom.c