media: atomisp: fix the uninitialized use and rename "retvalue"
authorYizhuo <yzhai003@ucr.edu>
Fri, 25 Jun 2021 05:38:56 +0000 (07:38 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 22 Jul 2021 12:01:55 +0000 (14:01 +0200)
commitc275e5d349b0d2b1143607d28b9c7c14a8a0a9b4
treea37ddbb4e5af0c5d4c2e2ae8d507e5893b9fc418
parent9d971b81359837ed05f466afa7c8df5d5f94786f
media: atomisp: fix the uninitialized use and rename "retvalue"

Inside function mt9m114_detect(), variable "retvalue" could
be uninitialized if mt9m114_read_reg() returns error, however, it
is used in the later if statement, which is potentially unsafe.

The local variable "retvalue" is renamed to "model" to avoid
confusion.

Link: https://lore.kernel.org/linux-media/20210625053858.3862-1-yzhai003@ucr.edu
Fixes: ad85094 (media / atomisp: fix the uninitialized use of model ID)
Signed-off-by: Yizhuo <yzhai003@ucr.edu>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c