net: ena: Fix undefined state when tx request id is out of bounds
authorArthur Kiyanovski <akiyano@amazon.com>
Sun, 2 Jan 2022 07:37:26 +0000 (07:37 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 2 Jan 2022 12:45:13 +0000 (12:45 +0000)
commitc255a34e02efb1393d23ffb205ba1a11320aeffb
treef18f9dfa275ea817b3d7513a895ee915a9c4d0e8
parentae81de737885820616f9c67c2e7935998b523d58
net: ena: Fix undefined state when tx request id is out of bounds

ena_com_tx_comp_req_id_get() checks the req_id of a received completion,
and if it is out of bounds returns -EINVAL. This is a sign that
something is wrong with the device and it needs to be reset.

The current code does not reset the device in this case, which leaves
the driver in an undefined state, where this completion is not properly
handled.

This commit adds a call to handle_invalid_req_id() in ena_clean_tx_irq()
and ena_clean_xdp_irq() which resets the device to fix the issue.

This commit also removes unnecessary request id checks from
validate_tx_req_id() and validate_xdp_req_id(). This check is unneeded
because it was already performed in ena_com_tx_comp_req_id_get(), which
is called right before these functions.

Fixes: 548c4940b9f1 ("net: ena: Implement XDP_TX action")
Signed-off-by: Shay Agroskin <shayagr@amazon.com>
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amazon/ena/ena_netdev.c