bpf: selftests: global_funcs: Check err_str before strstr
authorYauheni Kaliuta <yauheni.kaliuta@redhat.com>
Thu, 20 Aug 2020 11:58:43 +0000 (14:58 +0300)
committerAlexei Starovoitov <ast@kernel.org>
Thu, 20 Aug 2020 21:31:14 +0000 (14:31 -0700)
commitc210773d6c6f595f5922d56b7391fe343bc7310e
treed62c557e148a44a174ca14b55b6efd552ec0b39c
parentc8a36f1945b2b1b3f9823b66fc2181dc069cf803
bpf: selftests: global_funcs: Check err_str before strstr

The error path in libbpf.c:load_program() has calls to pr_warn()
which ends up for global_funcs tests to
test_global_funcs.c:libbpf_debug_print().

For the tests with no struct test_def::err_str initialized with a
string, it causes call of strstr() with NULL as the second argument
and it segfaults.

Fix it by calling strstr() only for non-NULL err_str.

Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/20200820115843.39454-1-yauheni.kaliuta@redhat.com
tools/testing/selftests/bpf/prog_tests/test_global_funcs.c