Debugger: clear ICs on activating step-in to correctly flood accessor pairs.
authoryangguo <yangguo@chromium.org>
Tue, 7 Jul 2015 13:56:17 +0000 (06:56 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 7 Jul 2015 13:57:16 +0000 (13:57 +0000)
commitc1b5d1743903c12880cbba3afaac9da1781d0a9f
tree0d4ebe7e8dccaaf299930e165c92c84c1d2d0fff
parent870ea40a8bcca15be1e44b2dba06700c312c10d8
Debugger: clear ICs on activating step-in to correctly flood accessor pairs.

If we compile handlers to call accessors, Debug::HandleStepIn won't get
called. Therefore we need to clear ICs each time. This has not been
necessary before because we used to patch ICs for breaking, and restored
them with cleared ICs. This is no longer the case. We do not use ICs
for breaking anymore, so they are not implicitly cleared any longer.

R=mvstanton@chromium.org
BUG=v8:4269
LOG=N

Review URL: https://codereview.chromium.org/1212253009

Cr-Commit-Position: refs/heads/master@{#29518}
src/debug.cc
src/debug.h
src/objects.cc
src/runtime/runtime-classes.cc
src/runtime/runtime-debug.cc
src/runtime/runtime-object.cc
test/mjsunit/debug-stepin-accessor-ic.js [new file with mode: 0644]