ucounts: Set ucount_max to the largest positive value the type can hold
authorAlexey Gladkov <legion@kernel.org>
Thu, 22 Apr 2021 12:27:16 +0000 (14:27 +0200)
committerEric W. Biederman <ebiederm@xmission.com>
Fri, 30 Apr 2021 19:14:03 +0000 (14:14 -0500)
commitc1ada3dc7219b02b3467aa906c2f5f8b098578d1
treeed42c25748ccbec5d4704b99d4934f1b6c91ffe8
parente4aebf06695c32d49f1007f9d252f97b5b2998a7
ucounts: Set ucount_max to the largest positive value the type can hold

The ns->ucount_max[] is signed long which is less than the rlimit size.
We have to protect ucount_max[] from overflow and only use the largest
value that we can hold.

On 32bit using "long" instead of "unsigned long" to hold the counts has
the downside that RLIMIT_MSGQUEUE and RLIMIT_MEMLOCK are limited to 2GiB
instead of 4GiB. I don't think anyone cares but it should be mentioned
in case someone does.

The RLIMIT_NPROC and RLIMIT_SIGPENDING used atomic_t so their maximum
hasn't changed.

Signed-off-by: Alexey Gladkov <legion@kernel.org>
Link: https://lkml.kernel.org/r/1825a5dfa18bc5a570e79feb05e2bd07fd57e7e3.1619094428.git.legion@kernel.org
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
include/linux/user_namespace.h
kernel/fork.c
kernel/user_namespace.c