[netdrvr] Drivers should not set IFF_* flag themselves
authorWang Chen <wangchen@cn.fujitsu.com>
Tue, 22 Jul 2008 05:13:12 +0000 (13:13 +0800)
committerJeff Garzik <jgarzik@redhat.com>
Thu, 7 Aug 2008 06:23:19 +0000 (02:23 -0400)
commitc16d118537cadb21d186e35aebad90a13cd78846
tree8fc1ab697f2476ecd2b39522efcf6234be3dc5c0
parentfe414248551e2880fe8913577699003ff145ab9d
[netdrvr] Drivers should not set IFF_* flag themselves

Some hardware set promisc when they are requested to set IFF_ALLMULTI flag.
It's ok, but if drivers set IFF_PROMISC flag when they set promisc,
it will broken upper layer handle for promisc and allmulti.
In addition, drivers can use their own hardware programming to make it.
So do not allow drivers to set IFF_* flags.

This is a general driver fix, so I didn't split it to pieces and send
to specific driver maintainers.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
13 files changed:
drivers/net/3c523.c
drivers/net/3c527.c
drivers/net/atp.c
drivers/net/de620.c
drivers/net/eepro.c
drivers/net/eth16i.c
drivers/net/lp486e.c
drivers/net/ni5010.c
drivers/net/ni52.c
drivers/net/sun3_82586.c
drivers/net/wireless/orinoco.c
drivers/net/wireless/wavelan.c
drivers/net/wireless/wavelan_cs.c