cfq-iosched: cleanup unreachable code
authorCorrado Zoccolo <czoccolo@gmail.com>
Thu, 26 Nov 2009 08:41:21 +0000 (09:41 +0100)
committerJens Axboe <jens.axboe@oracle.com>
Thu, 26 Nov 2009 08:46:46 +0000 (09:46 +0100)
commitc16632bab1a17e357cec66920ceb3f0630009360
tree6937755404314252f0bf2c46eec374c32c12f8b1
parent2d4dc890b5c8fabd818a8586607e6843c4375e62
cfq-iosched: cleanup unreachable code

cfq_should_idle returns false for no-idle queues that are not the last,
so the control flow will never reach the removed code in a state that
satisfies the if condition.
The unreachable code was added to emulate previous cfq behaviour for
non-NCQ rotational devices. My tests show that even without it, the
performances and fairness are comparable with previous cfq, thanks to
the fact that all seeky queues are grouped together, and that we idle at
the end of the tree.

Signed-off-by: Corrado Zoccolo <czoccolo@gmail.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
block/cfq-iosched.c