-Wimplicit-fallthrough: fixed two cases where "fallthrough annotation in unreachable...
authorAlexander Kornienko <alexfh@google.com>
Thu, 7 Feb 2013 02:17:19 +0000 (02:17 +0000)
committerAlexander Kornienko <alexfh@google.com>
Thu, 7 Feb 2013 02:17:19 +0000 (02:17 +0000)
commitc121b9b796e40f2eec2aabebb4dfcabe2f21537f
treeab79a43db91e27556b7780d125927e13c59262de
parent56ac51a92ef7102352e7ad81d518c3565af74d7d
-Wimplicit-fallthrough: fixed two cases where "fallthrough annotation in unreachable code" was issued incorrectly.

Summary:
-Wimplicit-fallthrough: fixed two cases where "fallthrough annotation in unreachable code" was issued incorrectly:

1. In actual unreachable code, but not immediately on a fall-through execution
path "fallthrough annotation does not directly precede switch label" is better;
2. After default: in a switch with covered enum cases. Actually, these shouldn't
be treated as unreachable code for our purpose.

Reviewers: rsmith

Reviewed By: rsmith

CC: cfe-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D374

llvm-svn: 174575
clang/lib/Sema/AnalysisBasedWarnings.cpp
clang/test/SemaCXX/switch-implicit-fallthrough.cpp