projects / platform / upstream / llvm.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9197bac) | patch
Add a static assertions for custom Op<> to not defined data members (NFC)
authorMehdi Amini <joker.eph@gmail.com>
Tue, 8 Jun 2021 18:28:39 +0000 (18:28 +0000)
committerMehdi Amini <joker.eph@gmail.com>
Tue, 8 Jun 2021 18:38:18 +0000 (18:38 +0000)
commitc0edcec630eb26e12d66dae2f0e1fbf5258cb6ac
tree63bb7b87fddabbcc6354d5c28fa6974ae11475e2tree | snapshot
parent9197bac297f73552882820ba25d245115e29e7afcommit | diff
Add a static assertions for custom Op<> to not defined data members (NFC)

A common mistake for newcomers to MLIR is to try to store extra member
on the Op class. However these are intended to be thing wrapper around
an Operation*, all the storage is meant to be encoded in attribute on
the underlying Operation. This can be confusing to debug, so better
catch it at build time.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D103869
mlir/include/mlir/IR/OpDefinition.h diff | blob | history
Domain: System / Toolchain;