[mlir][tblgen] Reverting fatality of assemblyFormat with skipDefaultBuilders=1
authorwren romano <2998727+wrengr@users.noreply.github.com>
Wed, 6 Jul 2022 22:42:53 +0000 (15:42 -0700)
committerwren romano <2998727+wrengr@users.noreply.github.com>
Thu, 7 Jul 2022 01:07:39 +0000 (18:07 -0700)
commitc0db2b75ac1c0ff4299adcf2c6781a1775a28bfb
tree98242f74582d4c31c7f9a96d963e42483deece53
parent21007259dc95370568370607bd437d27ce1cf9f8
[mlir][tblgen] Reverting fatality of assemblyFormat with skipDefaultBuilders=1

Per @rriddle, we do not want to require `skipDefaultBuilders=0` per se; that is, even though the `assemblyFormat`-generated parser requires a builder with the same prototype as the default-builder, that prototype could instead be implemented via custom `builders`.  This differential reduces the FatalError introduced in D128555 to a non-fatal Warning instead, so that users can still be informed of the error condition (rather than waiting for the C++ compiler to fail).

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D129234
mlir/lib/TableGen/AttrOrTypeDef.cpp