[MC] Defer asm errors to post-statement failure
authorNirav Dave <niravd@google.com>
Mon, 12 Sep 2016 20:03:02 +0000 (20:03 +0000)
committerNirav Dave <niravd@google.com>
Mon, 12 Sep 2016 20:03:02 +0000 (20:03 +0000)
commitc0c0f7a1966c7432ca1b0a5ce78e568cefec1e00
tree9d606ae2788f17ba0eba283c1e8e3b81483a0dd3
parentdea26950a020bfb65aeedcc5d2afaa574adbedbb
[MC] Defer asm errors to post-statement failure

Allow errors to be deferred and emitted as part of clean up to simplify
and shorten Assembly parser code. This will allow error messages to be
emitted in helper functions and be modified by the caller which has
better context.

As part of this many minor cleanups to the Parser:

* Unify parser cleanup on error
* Add Workaround for incorrect return values in ParseDirective instances
* Tighten checks on error-signifying return values for parser functions
  and fix in-tree TargetParsers to be more consistent with the changes.
* Fix AArch64 test cases checking for spurious error messages that are
  now fixed.

These changes should be backwards compatible with current Target Parsers
so long as the error status are correctly returned in appropriate
functions.

Reviewers: rnk, majnemer

Subscribers: aemerson, jyknight, llvm-commits

Differential Revision: https://reviews.llvm.org/D24047

llvm-svn: 281249
16 files changed:
llvm/include/llvm/MC/MCParser/MCAsmLexer.h
llvm/include/llvm/MC/MCParser/MCAsmParser.h
llvm/include/llvm/Support/SMLoc.h
llvm/lib/MC/MCParser/AsmParser.cpp
llvm/lib/MC/MCParser/MCAsmLexer.cpp
llvm/lib/MC/MCParser/MCAsmParser.cpp
llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
llvm/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp
llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
llvm/lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp
llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
llvm/test/MC/AArch64/armv8.1a-rdma.s
llvm/test/MC/AArch64/inst-directive-diagnostic.s
llvm/test/MC/AArch64/neon-diagnostics.s