projects / platform / upstream / nodejs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 54d5437) | patch
build,win: set env before generating projects
authorAlexis Campailla <alexis@janeasystems.com>
Thu, 23 Apr 2015 14:26:59 +0000 (07:26 -0700)
committerRod Vagg <rod@vagg.org>
Thu, 25 Jun 2015 03:00:00 +0000 (13:00 +1000)
commitc0c0d7326938afc689a2b6a59440956b3d054e4d
treedc3b26fbca1ce6662ebe01e9bf1a0824f37553c8tree | snapshot
parent54d5437566713beb05ad93775d97c21bc6200b66commit | diff
build,win: set env before generating projects

vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
PR-URL: https://github.com/joyent/node/pull/20109
vcbuild.bat diff | blob | history
Domain: Web Framework / Common;