remoteproc: qcom: pas: fix error handling in adsp_pds_enable
authorZhang Qilong <zhangqilong3@huawei.com>
Mon, 2 Nov 2020 14:35:54 +0000 (22:35 +0800)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 10 Dec 2020 19:23:15 +0000 (13:23 -0600)
commitc0a6e5ee1ecfe4c3a5799cfd30820748eff5dfab
treeb95745a3dee320eb11627b1d0d9553d067569edb
parentaa37448f597c09844942da87d042fc6793f989c2
remoteproc: qcom: pas: fix error handling in adsp_pds_enable

If the pm_runtime_get_sync failed in adsp_pds_enable when
loop (i), The unroll_pd_votes will start from (i - 1), and
it will resulted in following problems:

  1) pm_runtime_get_sync will increment pm usage counter even it
     failed. Forgetting to pm_runtime_put_noidle will result in
     reference leak.

  2) Have not reset pds[i] performance state.

Then we fix it.

Fixes: 17ee2fb4e8567 ("remoteproc: qcom: pas: Vote for active/proxy power domains")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201102143554.144707-1-zhangqilong3@huawei.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_q6v5_pas.c