KVM: x86: fix deadlock in clock-in-progress request handling
authorMarcelo Tosatti <mtosatti@redhat.com>
Mon, 18 Mar 2013 16:54:32 +0000 (13:54 -0300)
committerMarcelo Tosatti <mtosatti@redhat.com>
Mon, 18 Mar 2013 21:03:39 +0000 (18:03 -0300)
commitc09664bb44184b3846e8c5254db4eae4b932682a
treee37f7b8a0840008d3bb4f73f79ee71f4cf8df6c3
parentf445f11eb2cc265dd47da5b2e864df46cd6e5a82
KVM: x86: fix deadlock in clock-in-progress request handling

There is a deadlock in pvclock handling:

cpu0:                                               cpu1:
kvm_gen_update_masterclock()
                                              kvm_guest_time_update()
 spin_lock(pvclock_gtod_sync_lock)
                                               local_irq_save(flags)

spin_lock(pvclock_gtod_sync_lock)

 kvm_make_mclock_inprogress_request(kvm)
  make_all_cpus_request()
   smp_call_function_many()

Now if smp_call_function_many() called by cpu0 tries to call function on
cpu1 there will be a deadlock.

Fix by moving pvclock_gtod_sync_lock protected section outside irq
disabled section.

Analyzed by Gleb Natapov <gleb@redhat.com>
Acked-by: Gleb Natapov <gleb@redhat.com>
Reported-and-Tested-by: Yongjie Ren <yongjie.ren@intel.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
arch/x86/kvm/x86.c