child_process: use full path for cmd.exe on Win32
authorEd Morley <emorley@mozilla.com>
Tue, 13 May 2014 12:20:36 +0000 (13:20 +0100)
committerFedor Indutny <fedor@indutny.com>
Tue, 24 Jun 2014 04:44:11 +0000 (08:44 +0400)
commitc08da463adab71c05017ad6fe81927fa66e2e11e
treea5b3cb6b4f96e9d810b75a248bdd0e5315f54089
parent4f1782ef750fb171eb90a1d97b14e2ed3a8a165d
child_process: use full path for cmd.exe on Win32

Currently child_process.exec() assumes that cmd.exe is on the PATH,
and fails with a spawn ENOENT error if it is not.

The Windows 'comspec' environment variable contains the full filepath
to the default command interpreter, eg "C:\Windows\System32\cmd.exe".
Should it not be set, we fall-back to using 'cmd.exe' from PATH, as
before.

Signed-off-by: Fedor Indutny <fedor@indutny.com>
lib/child_process.js