Jit intrinsics for Span<T>.get_Item and ReadOnlySpan<T>.get_Item. (#10910)
authorAndy Ayers <andya@microsoft.com>
Mon, 17 Apr 2017 20:04:23 +0000 (13:04 -0700)
committerGitHub <noreply@github.com>
Mon, 17 Apr 2017 20:04:23 +0000 (13:04 -0700)
commitc06fb332e7bb77a55bda724a56b33d6094a0a042
treecf393ffb3e1e0c1a022bf344be41241e9e2272ef
parent81c550179aef561fd6578109ff65185d1daafe8b
Jit intrinsics for Span<T>.get_Item and ReadOnlySpan<T>.get_Item. (#10910)

Implement these two methods as optional-expand jit intrinsics.
Uses `GT_ARR_BOUNDS_CHECK` for the bounds check so in some cases
downstream code is able to eliminate redundant checks. Fully general
support (on par with arrays in most cases) is still work in progress.

Update one bit of code in the optimizer that assumed it knew the
tree types that appeared in a `GT_ARR_BOUNDS_CHECK`.

Add benchmark tests for Span and ReadOnlySpan indexers.

Tests ability of jit to reason about indexer properties with respect
to loop bounds and related indexer uses. Some cases inspired by span
indexer usage in Kestrel.

Closes #10785.

Also addresses lack of indexer inlining noted in #10031. Span indexers
should now always be inlined, even when invoked from shared methods.
src/inc/corinfo.h
src/jit/importer.cpp
src/jit/optimizer.cpp
src/vm/jitinterface.cpp
src/vm/method.cpp
src/vm/mscorlib.h
tests/src/JIT/Performance/CodeQuality/Span/Indexer.cs [new file with mode: 0644]
tests/src/JIT/Performance/CodeQuality/Span/Indexer.csproj [new file with mode: 0644]
tests/src/JIT/config/benchmark/project.json