io_uring: always lock in io_apoll_task_func
authorDylan Yudaken <dylany@meta.com>
Thu, 24 Nov 2022 09:35:52 +0000 (01:35 -0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 25 Nov 2022 13:10:04 +0000 (06:10 -0700)
commitc06c6c5d276707e04cedbcc55625e984922118aa
tree3dc0897408081f1631a2bab7b44c31d9286e8af9
parent2dac1a159216b39ced8d78dba590c5d2f4249586
io_uring: always lock in io_apoll_task_func

This is required for the failure case (io_req_complete_failed) and is
missing.

The alternative would be to only lock in the failure path, however all of
the non-error paths in io_poll_check_events that do not do not return
IOU_POLL_NO_ACTION end up locking anyway. The only extraneous lock would
be for the multishot poll overflowing the CQE ring, however multishot poll
would probably benefit from being locked as it will allow completions to
be batched.

So it seems reasonable to lock always.

Signed-off-by: Dylan Yudaken <dylany@meta.com>
Link: https://lore.kernel.org/r/20221124093559.3780686-3-dylany@meta.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/poll.c