ext4: fix memory leak in parse_apply_sb_mount_options()
authorEric Biggers <ebiggers@google.com>
Fri, 13 May 2022 23:16:01 +0000 (16:16 -0700)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 18 May 2022 15:24:22 +0000 (11:24 -0400)
commitc069db76ed7b681c69159f44be96d2137e9ca989
tree107874422624814e1e75b31a68f6f409725439c1
parentcb8435dc8ba33bcafa41cf2aa253794320a3b8df
ext4: fix memory leak in parse_apply_sb_mount_options()

If processing the on-disk mount options fails after any memory was
allocated in the ext4_fs_context, e.g. s_qf_names, then this memory is
leaked.  Fix this by calling ext4_fc_free() instead of kfree() directly.

Reproducer:

    mkfs.ext4 -F /dev/vdc
    tune2fs /dev/vdc -E mount_opts=usrjquota=file
    echo clear > /sys/kernel/debug/kmemleak
    mount /dev/vdc /vdc
    echo scan > /sys/kernel/debug/kmemleak
    sleep 5
    echo scan > /sys/kernel/debug/kmemleak
    cat /sys/kernel/debug/kmemleak

Fixes: 7edfd85b1ffd ("ext4: Completely separate options parsing and sb setup")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Tested-by: Ritesh Harjani <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/20220513231605.175121-2-ebiggers@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/super.c