fortran: Fix conv of UNION constructors [PR105310]
authorFritz Reese <foreese@gcc.gnu.org>
Tue, 19 Apr 2022 20:45:46 +0000 (16:45 -0400)
committerFritz Reese <foreese@gcc.gnu.org>
Thu, 21 Apr 2022 14:13:59 +0000 (10:13 -0400)
commitc049f638da4f7b32b11e4d895184e0960bae5291
tree0378cadec8364709478b2a23de14677615c96b5c
parent1e6c0e69af8da436e1d1d2d23d8c38410d78ecf2
fortran: Fix conv of UNION constructors [PR105310]

This fixes an ICE when a UNION is the (1+8*2^n)-th field in a DEC
STRUCTURE when compiled with -finit-derived -finit-local-zero.
The problem was CONSTRUCTOR_APPEND_ELT from within gfc_conv_union_initializer
modified the vector pointer, but the pointer was passed by-value,
so the old pointer from the caller (gfc_conv_structure) pointed to freed
memory.

PR fortran/105310

gcc/fortran/ChangeLog:

* trans-expr.cc (gfc_conv_union_initializer): Pass vec* by reference.

gcc/testsuite/ChangeLog:

* gfortran.dg/dec_union_12.f90: New test.
gcc/fortran/trans-expr.cc
gcc/testsuite/gfortran.dg/dec_union_12.f90 [new file with mode: 0755]