perf evsel: Separate bpf_counter_list and bpf_filters, can be used at the same time
authorSong Liu <song@kernel.org>
Fri, 19 May 2023 23:57:57 +0000 (16:57 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 26 May 2023 19:03:43 +0000 (16:03 -0300)
commitc041d33bf7ec731bb71f47e4d45a7aec9e40b1b9
tree6b7da3442db1e3a6960452940afffa2462dcd881
parentc8268a9b91055c992909a0845cfa59c624908da8
perf evsel: Separate bpf_counter_list and bpf_filters, can be used at the same time

'struct evsel' uses a union for the two lists. This turned out to be
error prone.

For example:

  [root@quaco ~]# perf stat --bpf-prog 5246
  Error: cpu-clock event does not have sample flags 66c660
  failed to set filter "(null)" on event cpu-clock with 2 (No such file or directory)
  [root@quaco ~]# perf stat --bpf-prog 5246

Fix this issue by separating the two lists.

Fixes: 56ec9457a4a20c5e ("perf bpf filter: Implement event sample filtering")
Signed-off-by: Song Liu <song@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: kernel-team@meta.com
Link: https://lore.kernel.org/r/20230519235757.3613719-1-song@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/evsel.c
tools/perf/util/evsel.h