virtio: move bi-endian target support to a single location
authorGreg Kurz <gkurz@linux.vnet.ibm.com>
Tue, 31 May 2016 08:09:54 +0000 (10:09 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 7 Jun 2016 12:39:28 +0000 (15:39 +0300)
commitc02d7030c3c538312c7f464cb79b72c29a20df74
tree460b25c3f584db57a1aaf09ed00d7224e449a127
parent9f318f8f7e689b9653b42bac73047f9719a1f34e
virtio: move bi-endian target support to a single location

Paolo's recent cpu.h cleanups broke legacy virtio for ppc64 LE guests (and
arm BE guests as well, even if I have not verified that). Especially, commit
"33c11879fd42 qemu-common: push cpu.h inclusion out of qemu-common.h" has
the side-effect of silently hiding the TARGET_IS_BIENDIAN macro from the
virtio memory accessors, and thus fully disabling support of endian changing
targets.

To be sure this cannot happen again, let's gather all the bi-endian bits
where they belong in include/hw/virtio/virtio-access.h.

The changes in hw/virtio/vhost.c are safe because vhost_needs_vring_endian()
is not called on a hot path and non bi-endian targets will return false
anyway.

While here, also rename TARGET_IS_BIENDIAN to be more precise: it is only for
legacy virtio and bi-endian guests.

Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
hw/virtio/vhost.c
include/hw/virtio/virtio-access.h
target-arm/cpu.h
target-ppc/cpu.h