staging: dgnc: Fix a sleep-in-atomic-context bug in cls_assert_modem_signals()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Sat, 15 Sep 2018 03:13:03 +0000 (11:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Sep 2018 11:29:10 +0000 (13:29 +0200)
commitbffa9b1cc64a12f3162f79151dee56199efbc785
treed7a541b5324a9b1e7d168c8fdf8d6a29a31fcd5f
parent2051c6ae928ddbd4d314ba8ea89298d686ad86b7
staging: dgnc: Fix a sleep-in-atomic-context bug in cls_assert_modem_signals()

The driver may sleep with holding a spinlock.
The function call path (from bottom to top) in Linux-4.17 is:

[FUNC] usleep_range
drivers/staging/dgnc/dgnc_cls.c, 391:
usleep_range in cls_assert_modem_signals
drivers/staging/dgnc/dgnc_cls.c, 449:
cls_assert_modem_signals in cls_copy_data_from_queue_to_uart
drivers/staging/dgnc/dgnc_cls.c, 406:
_raw_spin_lock_irqsave in cls_copy_data_from_queue_to_uart

To fix this bug, usleep_range() is replaced with udelay().

This bug is found by my static analysis tool DSAC.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgnc/dgnc_cls.c