f2fs: prevent creating duplicate encrypted filenames
authorEric Biggers <ebiggers@google.com>
Wed, 18 Nov 2020 07:56:07 +0000 (23:56 -0800)
committerEric Biggers <ebiggers@google.com>
Tue, 24 Nov 2020 23:10:27 +0000 (15:10 -0800)
commitbfc2b7e8518999003a61f91c1deb5e88ed77b07d
treefdf6b3acdbd5d2a07f1fca0e6bd7d74a071c618f
parent75d18cd1868c2aee43553723872c35d7908f240f
f2fs: prevent creating duplicate encrypted filenames

As described in "fscrypt: add fscrypt_is_nokey_name()", it's possible to
create a duplicate filename in an encrypted directory by creating a file
concurrently with adding the directory's encryption key.

Fix this bug on f2fs by rejecting no-key dentries in f2fs_add_link().

Note that the weird check for the current task in f2fs_do_add_link()
seems to make this bug difficult to reproduce on f2fs.

Fixes: 9ea97163c6da ("f2fs crypto: add filename encryption for f2fs_add_link")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201118075609.120337-4-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
fs/f2fs/f2fs.h