Merge branch 'bpftool: fix feature output when helper probes fail'
authorAndrii Nakryiko <andrii@kernel.org>
Tue, 10 May 2022 00:16:05 +0000 (17:16 -0700)
committerAndrii Nakryiko <andrii@kernel.org>
Tue, 10 May 2022 00:16:05 +0000 (17:16 -0700)
commitbfa92e0bdc8ee5d444086fa25489de861a17b085
treefcfdc05cea7c63cb457c771f560047bfa8371197
parent7b3a06382442c4d83c9d35253638cb3f561da9b9
parentb06a92a18d4651c983c60d83935a76b2d47d85e0
Merge branch 'bpftool: fix feature output when helper probes fail'

Milan Landaverde says:

====================

Currently in bpftool's feature probe, we incorrectly tell the user that
all of the helper functions are supported for program types where helper
probing fails or is explicitly unsupported[1]:

$ bpftool feature probe
...
eBPF helpers supported for program type tracing:
- bpf_map_lookup_elem
- bpf_map_update_elem
- bpf_map_delete_elem
...
- bpf_redirect_neigh
- bpf_check_mtu
- bpf_sys_bpf
- bpf_sys_close

This patch adjusts bpftool to relay to the user when helper support
can't be determined:

$ bpftool feature probe
...
eBPF helpers supported for program type lirc_mode2:
    Program type not supported
eBPF helpers supported for program type tracing:
    Could not determine which helpers are available
eBPF helpers supported for program type struct_opts:
    Could not determine which helpers are available
eBPF helpers supported for program type ext:
    Could not determine which helpers are available

Rather than imply that no helpers are available for the program type, we
let the user know that helper function probing failed entirely.

[1] https://lore.kernel.org/bpf/20211217171202.3352835-2-andrii@kernel.org/
====================

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>