Remove calls to suspend/resume atomic helpers from amdgpu_device_gpu_recover. (v2)
authorAndrey Grodzovsky <andrey.grodzovsky@amd.com>
Thu, 17 May 2018 15:18:34 +0000 (11:18 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 24 May 2018 04:51:20 +0000 (23:51 -0500)
commitbf83060408fea52eccdcf695f3b4b16c71207691
tree4155701722c5850cec2810ca05fad6276b40580f
parentdef139037bbf9195467fa83c0a299d666e6ed0bb
Remove calls to suspend/resume atomic helpers from amdgpu_device_gpu_recover. (v2)

First of all it's already being called from the display code from amd_ip_funcs.suspend/resume hooks.
Second of all, the place in amdgpu_device_gpu_recover it's being called is wrong for GPU stalls since
it is called BEFORE we cancel and force completion of all in flight jobs which were not yet processed.
So, as Bas pointed in the ticket we will try to wait for fence  in amdgpu_pm_compute_clocks but the pipe
is hanged so we end up in deadlock.

v2: remove unused variable

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106500
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c