Revert "Reland "[lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if...
authorMichael Buch <michaelbuch12@gmail.com>
Mon, 13 Feb 2023 18:04:44 +0000 (18:04 +0000)
committerMichael Buch <michaelbuch12@gmail.com>
Mon, 13 Feb 2023 18:09:32 +0000 (18:09 +0000)
commitbf7c421617007d7202dcd74762cef3a49425bfab
tree792a1e4ea897852b45ac21e8f655f7b7601ba40f
parent8a57748804bd2247a8c0c5632af3364db58a087f
Revert "Reland "[lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing""

This reverts commit 19128792e2aa320c1a149f7f93638cbd7f3c83c6.

As pointed out in https://reviews.llvm.org/D143652 this implementation
doesn't quite work for subobject constructors/destructors because DWARF
can map multiple definitions of a ctor/dtor to the same specification DIE.
With the current implementation we would pick the first definition we
find and use that linkage name which means we can sometimes pick the
wrong dtor/ctor and fail to execute a valid expression.

Differential Revision: https://reviews.llvm.org/D143652
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
lldb/test/API/lang/cpp/external_ctor_dtor_lookup/Makefile [deleted file]
lldb/test/API/lang/cpp/external_ctor_dtor_lookup/TestExternalCtorDtorLookup.py [deleted file]
lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.h [deleted file]
lldb/test/API/lang/cpp/external_ctor_dtor_lookup/main.cpp [deleted file]