libstdc++: Tell GCC what basic_string::_M_is_local() means [PR109299]
authorJonathan Wakely <jwakely@redhat.com>
Tue, 28 Mar 2023 09:50:40 +0000 (10:50 +0100)
committerJonathan Wakely <jwakely@redhat.com>
Tue, 28 Mar 2023 20:12:18 +0000 (21:12 +0100)
commitbf78b43873b0b7e8f9a430df38749b8b61f9c9b8
treeff6f661fe5972bb61b27e118123eb5eeeb4808e0
parentcf19ef9eca82b01dd0a3a0a8e4c8bcec236eb2d9
libstdc++: Tell GCC what basic_string::_M_is_local() means [PR109299]

This avoids a bogus warning about overflowing a buffer, because GCC
can't tell that we don't copy into the buffer unless it fits. By adding
a __builtin_unreachable() hint we inform the compiler about the
invariant that the buffer is only used when it's big enough.

This can also improve codegen, by eliminating dead code that GCC
couldn't tell was unreachable.

libstdc++-v3/ChangeLog:

PR libstdc++/109299
* include/bits/basic_string.h (basic_string::_M_is_local()): Add
hint for compiler that local strings fit in the local buffer.
libstdc++-v3/include/bits/basic_string.h