init: Do not warn on non-zero initcall return
authorSteven Rostedt <rostedt@goodmis.org>
Wed, 1 May 2013 17:35:51 +0000 (13:35 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 1 May 2013 17:44:24 +0000 (10:44 -0700)
commitbf5d770bd234a1e66322dd79c4ae5b397cd2b9c1
treeb92a59f7e8cc4417fb2ab853fc08c5dd21538581
parenta49fe6d59aae7f7835288df508b709ed2d69cbab
init: Do not warn on non-zero initcall return

Commit f91eb62f71b3 ("init: scream bloody murder if interrupts are
enabled too early") added three new warnings.  The first two seemed
reasonable, but the third included a warning when an initcall returned
non-zero.  Although, the third WARN() does include an imbalanced preempt
disabled, or irqs disable, it shouldn't warn if it only had an initcall
that just returns non-zero.

In fact, according to Linus, it shouldn't print at all.  As it only
prints with initcall_debug set, and that already shows enough
information to fix things.

Link: http://lkml.kernel.org/r/CA+55aFzaBC5SFi7=F2mfm+KWY5qTsBmOqgbbs8E+LUS8JK-sBg@mail.gmail.com
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
init/main.c