ceph: reduce contention in ceph_check_delayed_caps()
authorLuis Henriques <lhenriques@suse.de>
Tue, 6 Jul 2021 13:52:41 +0000 (14:52 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Wed, 4 Aug 2021 17:20:05 +0000 (19:20 +0200)
commitbf2ba432213fade50dd39f2e348085b758c0726e
tree93d7a166a733d9a2cbac1e13eafb639aaaf02dd6
parentc500bee1c5b2f1d59b1081ac879d73268ab0ff17
ceph: reduce contention in ceph_check_delayed_caps()

Function ceph_check_delayed_caps() is called from the mdsc->delayed_work
workqueue and it can be kept looping for quite some time if caps keep
being added back to the mdsc->cap_delay_list.  This may result in the
watchdog tainting the kernel with the softlockup flag.

This patch breaks this loop if the caps have been recently (i.e. during
the loop execution).  Any new caps added to the list will be handled in
the next run.

Also, allow schedule_delayed() callers to explicitly set the delay value
instead of defaulting to 5s, so we can ensure that it runs soon
afterward if it looks like there is more work.

Cc: stable@vger.kernel.org
URL: https://tracker.ceph.com/issues/46284
Signed-off-by: Luis Henriques <lhenriques@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/caps.c
fs/ceph/mds_client.c
fs/ceph/super.h