scsi: scsi_transport_srp: Sanitize scsi_target_block/unblock sequences
authorHannes Reinecke <hare@suse.de>
Tue, 28 Jul 2020 13:48:33 +0000 (15:48 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 31 Jul 2020 01:15:26 +0000 (21:15 -0400)
commitbf1a28f92a8b00ee8ce48cc11338980e31ddb7b3
treeef98675608a7011c683029c79ad8f133a6a5c0e0
parentd61fa5bc3e521211d68d00c9199a61a7504b4dab
scsi: scsi_transport_srp: Sanitize scsi_target_block/unblock sequences

The SCSI midlayer does not allow state transitions from SDEV_BLOCK to
SDEV_BLOCK so calling scsi_target_block() from __rport_fast_io_fail() is
wrong as the port is already blocked.  Similarly, we don't need to call
scsi_target_unblock() afterwards as the function has already done this.

Link: https://lore.kernel.org/r/20200728134833.42547-1-hare@suse.de
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_transport_srp.c