sfc: fix use-after-free in efx_tc_flower_record_encap_match()
authorEdward Cree <ecree.xilinx@gmail.com>
Fri, 12 May 2023 15:35:58 +0000 (16:35 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 13 May 2023 19:58:17 +0000 (20:58 +0100)
commitbefcc1fce564bdb20ee55be981a355b0a7d0eac5
treeef33c16fd8d731ccd503c58d0387876f3cb0505d
parenta0b7955310a445fc0d45a0ac576bad8720cd6057
sfc: fix use-after-free in efx_tc_flower_record_encap_match()

When writing error messages to extack for pseudo collisions, we can't
 use encap->type as encap has already been freed.  Fortunately the
 same value is stored in local variable em_type, so use that instead.

Fixes: 3c9561c0a5b9 ("sfc: support TC decap rules matching on enc_ip_tos")
Reported-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/tc.c