Smack: fix use-after-free in smk_write_relabel_self()
authorEric Biggers <ebiggers@google.com>
Wed, 8 Jul 2020 20:15:20 +0000 (13:15 -0700)
committerCasey Schaufler <casey@schaufler-ca.com>
Tue, 14 Jul 2020 18:19:58 +0000 (11:19 -0700)
commitbeb4ee6770a89646659e6a2178538d2b13e2654e
tree696114e949661e6ee6fe7ec0ddc5e04603ed44ba
parentb3a9e3b9622ae10064826dccb4f7a52bd88c7407
Smack: fix use-after-free in smk_write_relabel_self()

smk_write_relabel_self() frees memory from the task's credentials with
no locking, which can easily cause a use-after-free because multiple
tasks can share the same credentials structure.

Fix this by using prepare_creds() and commit_creds() to correctly modify
the task's credentials.

Reproducer for "BUG: KASAN: use-after-free in smk_write_relabel_self":

#include <fcntl.h>
#include <pthread.h>
#include <unistd.h>

static void *thrproc(void *arg)
{
int fd = open("/sys/fs/smackfs/relabel-self", O_WRONLY);
for (;;) write(fd, "foo", 3);
}

int main()
{
pthread_t t;
pthread_create(&t, NULL, thrproc, NULL);
thrproc(NULL);
}

Reported-by: syzbot+e6416dabb497a650da40@syzkaller.appspotmail.com
Fixes: 38416e53936e ("Smack: limited capability for changing process label")
Cc: <stable@vger.kernel.org> # v4.4+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
security/smack/smackfs.c