mtd: spi-nor: core: Fix an issue of releasing resources during read/write
authorXiang Chen <chenxiang66@hisilicon.com>
Thu, 1 Apr 2021 07:34:46 +0000 (15:34 +0800)
committerTudor Ambarus <tudor.ambarus@microchip.com>
Sun, 11 Apr 2021 07:36:28 +0000 (10:36 +0300)
commitbe94215be1ab19e5d38f50962f611c88d4bfc83a
treef42e52fc4bb64010ca9f70817fd4f0c8a04d6562
parentb206b82d1726f6f878891791069ab0aea2e31113
mtd: spi-nor: core: Fix an issue of releasing resources during read/write

If rmmod the driver during read or write, the driver will release the
resources which are used during read or write, so it is possible to
refer to NULL pointer.

Use the testcase "mtd_debug read /dev/mtd0 0xc00000 0x400000 dest_file &
sleep 0.5;rmmod spi_hisi_sfc_v3xx.ko", the issue can be reproduced in
hisi_sfc_v3xx driver.

To avoid the issue, fill the interface _get_device and _put_device of
mtd_info to grab the reference to the spi controller driver module, so
the request of rmmod the driver is rejected before read/write is finished.

Fixes: b199489d37b2 ("mtd: spi-nor: add the framework for SPI NOR")
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Tested-by: Michael Walle <michael@walle.cc>
Tested-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Michael Walle <michael@walle.cc>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/1617262486-4223-1-git-send-email-yangyicong@hisilicon.com
drivers/mtd/spi-nor/core.c