xen/netback: don't queue unlimited number of packages
authorJuergen Gross <jgross@suse.com>
Tue, 30 Nov 2021 07:36:12 +0000 (08:36 +0100)
committerJuergen Gross <jgross@suse.com>
Thu, 16 Dec 2021 07:43:12 +0000 (08:43 +0100)
commitbe81992f9086b230623ae3ebbc85ecee4d00a3d3
tree57055bd29266dbda10157145f992322286b27ad8
parent6032046ec4b70176d247a71836186d47b25d1684
xen/netback: don't queue unlimited number of packages

In case a guest isn't consuming incoming network traffic as fast as it
is coming in, xen-netback is buffering network packages in unlimited
numbers today. This can result in host OOM situations.

Commit f48da8b14d04ca8 ("xen-netback: fix unlimited guest Rx internal
queue and carrier flapping") meant to introduce a mechanism to limit
the amount of buffered data by stopping the Tx queue when reaching the
data limit, but this doesn't work for cases like UDP.

When hitting the limit don't queue further SKBs, but drop them instead.
In order to be able to tell Rx packages have been dropped increment the
rx_dropped statistics counter in this case.

It should be noted that the old solution to continue queueing SKBs had
the additional problem of an overflow of the 32-bit rx_queue_len value
would result in intermittent Tx queue enabling.

This is part of XSA-392

Fixes: f48da8b14d04ca8 ("xen-netback: fix unlimited guest Rx internal queue and carrier flapping")
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
drivers/net/xen-netback/rx.c