ext4: clean up ext4_ext_convert_to_initialized() error handling
authorEric Whitney <enwlinux@gmail.com>
Thu, 30 Apr 2020 18:53:20 +0000 (14:53 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 4 Jun 2020 03:16:50 +0000 (23:16 -0400)
commitbe809e1274ebc043640eeeb287accb7b4a4bcbff
tree9eb081fdf095f7e043cd1941533ad2dc9410fea1
parent779e26517b3600830fe58933d5f97627711c9435
ext4: clean up ext4_ext_convert_to_initialized() error handling

If ext4_ext_convert_to_initialized() fails when called within
ext4_ext_handle_unwritten_extents(), immediately error out through the
exit point at function end.  Fix the error handling in the event
ext4_ext_convert_to_initialized() returns 0, which it shouldn't do when
converting an existing extent.  The current code returns the passed in
value of allocated (which is likely non-zero) while failing to set
m_flags, m_pblk, and m_len.

Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Link: https://lore.kernel.org/r/20200430185320.23001-5-enwlinux@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/extents.c