projects / platform / upstream / gst-plugins-base.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 0ac4fda) | patch
videodecoder: Call drain() rather then finish() on segment-done
authorNicolas Dufresne <nicolas.dufresne@collabora.com>
Wed, 16 Jun 2021 18:49:14 +0000 (14:49 -0400)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Wed, 23 Jun 2021 20:31:06 +0000 (20:31 +0000)
commitbe6793d0d18b28c8ce1a165dec415ae6ec0dc7c4
tree6a7caa890df5ce0c5d9c11e3d0f9b70d673e11ectree | snapshot
parent0ac4fda2d6c64b4bfae1a698335da3d9468e811acommit | diff
videodecoder: Call drain() rather then finish() on segment-done

The finish() virtual function documentation state that "Sub-classes can refuse
to decode new data after." Though, it is very common to issue a non-flushing
seek after that event in gapless playback uses case. This fixes potential
stalls with code using segment seeks, by using drain() virtual funciton
instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1206>
gst-libs/gst/video/gstvideodecoder.c diff | blob | history
Domain: Multimedia / Media Common;