scsi: bnx2i: fix potential use after free
authorPan Bian <bianpan2016@163.com>
Wed, 6 Nov 2019 12:32:21 +0000 (20:32 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Jan 2020 07:22:58 +0000 (08:22 +0100)
commitbe4e660bcade06e33a198e6be10d9c03305a663b
tree7f71c59c3b804ef8b46921b699977f46dd5e67ad
parent43c5bca0c4b3cf921836a4da78a5d6aea30d4e7e
scsi: bnx2i: fix potential use after free

commit 29d28f2b8d3736ac61c28ef7e20fda63795b74d9 upstream.

The member hba->pcidev may be used after its reference is dropped. Move the
put function to where it is never used to avoid potential use after free
issues.

Fixes: a77171806515 ("[SCSI] bnx2i: Removed the reference to the netdev->base_addr")
Link: https://lore.kernel.org/r/1573043541-19126-1-git-send-email-bianpan2016@163.com
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/bnx2i/bnx2i_iscsi.c