Don't suppress warning about dllimport on typedefs etc. in MicrosoftExt mode
authorHans Wennborg <hans@hanshq.net>
Fri, 23 May 2014 20:16:41 +0000 (20:16 +0000)
committerHans Wennborg <hans@hanshq.net>
Fri, 23 May 2014 20:16:41 +0000 (20:16 +0000)
commitbe4be16be3f358e08cba4676f057e46d51e08297
tree41c72fc90f7fe26253afb27410bb95b7e436a128
parent839e30b2c07347b1538587693e7ed014c345b74b
Don't suppress warning about dllimport on typedefs etc. in MicrosoftExt mode

It's true the MSVC doesn't warn about dllimport when applied to e.g. a typedef,
but that applies to dllexport too. I'd like us to be consistent, and I think
the right thing to do is to warn.

The original test that came with implementing the old behaviour doesn't provide
a good motivation, and it said it was checking that we're not repoting an *error*,
which is still true since this is just a warning.

There are plenty of tests e.g. in Sema/dllimport.c to check that we do warn
about dllimport on non functions or variables.

Differential Revision: http://reviews.llvm.org/D3832

llvm-svn: 209546
clang/include/clang/Basic/Attr.td
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/Rewriter/dllimport-typedef.c [deleted file]